Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): refactor bind set returning functions #16316

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Aug 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor bind set returning functions

  • refactor bind set returning functions
  • fix set returning function can't find alias columns
root@0.0.0.0:48000/default> SELECT parse_json('{"k": [1, 2, 3]}') config, json_array_elements(config:k);

SELECT parse_json('{"k": [1, 2, 3]}') AS config, json_array_elements(config:k)

┌───────────────────────────────────────────────┐
│     config    │ json_array_elements(config:k) │
│    Variant    │       Nullable(Variant)       │
├───────────────┼───────────────────────────────┤
│ {"k":[1,2,3]} │ 1                             │
│ {"k":[1,2,3]} │ 2                             │
│ {"k":[1,2,3]} │ 3                             │
└───────────────────────────────────────────────┘
3 rows read in 0.087 sec. Processed 1 rows, 1 B (11.53 rows/s, 11 B/s)

fixes: #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and andylokandy August 22, 2024 15:52
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 22, 2024
@b41sh b41sh added this pull request to the merge queue Aug 23, 2024
Merged via the queue into databendlabs:main with commit 5ebdfbe Aug 23, 2024
69 checks passed
@b41sh b41sh deleted the refactor-srf branch August 23, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants